search

enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.36k stars 324 forks source link

test/Benchmarks appear to never finish #6523

Closed hubertp closed 1 year ago

hubertp commented 1 year ago

Bisecting revealed the dispatch change to be the culprit. Needs investigation.

hubertp commented 1 year ago

It appears that https://github.com/enso-org/enso/blob/develop/engine/runtime/src/main/java/org/enso/interpreter/node/callable/InvokeMethodNode.java#L125 somehow leads to a circular dependency when resolving symbol of Meta.meta. I wonder if Any importing Meta has anything to do with it.

enso-bot[bot] commented 1 year ago

Hubert Plociniczak reports a new STANDUP for yesterday (2023-05-03):

Progress: Investigating reported problem with benchmarks. Bisecting revealed that changing resolution for functions is the culprit. Preliminary PR is up; identified slow symbol resolution for Any that is present on the hot path. Finished test case for #6525. Fighting with random failures on CI. Started looking into artificially limiting number of warnings attached to values. It should be finished by 2023-05-04.

Next Day: Next day I will be working on the #6523 task. Not quite happy with the solution, will need further improvements and testing.

enso-bot[bot] commented 1 year ago

Hubert Plociniczak reports a new STANDUP for yesterday (2023-05-04):

Progress: More tweaks to inline caching as per review. Trying to reproduce #6515 given more logs. Looks like there is some race-condition on shutdown. Verifying FQN/Import bug #6553. Adding limit to reported warnings and more benchmarks. It should be finished by 2023-05-04.

Next Day: Next day I will be working on the #6523 task. More tweaks to warnings, take over renaming project bug from Dmitry.