Closed kazcw closed 6 months ago
I have a fix for Case 1 in #6991, so this bug tracks fixing Case 2.
Added case 3 to this bug, because it's a similar problem.
Case 4: Detached edges can coexist with FS viz, with interesting results:
The current approach of explicitly clearing detached edges in response to certain events is fragile; we can easily miss cases, and if we use that approach to fix every known case it will add up to a lot of complexity. I think the ideal solution for all the different cases of conflicting actions is to build on the new exclusive-focus API. If we have a display object that acts as the focus receiver for all detached edges, we can listen for its defocus event and clear all detached edges if anything takes focus. Then, it's a matter of ensuring focus is captured by whatever action is the single current action (expression edit, FS viz, detached edges, etc).
The issues seem to be fixed in new GUI: any click outside CB now closes it, ctrl+click at port does not connect.
I'm not sure how to make fullscreen viz while having detached edge. To be checked once shortcut for fullscreen viz will land.
Discord username
No response
What type of issue is this?
Permanent – Occurring repeatably
Is this issue blocking you from using Enso?
Is this a regression?
What issue are you facing?
We currently allow a state where a detached edge is following the mouse, and the cursor is editing a node's expression at the same time. This kind of state can be reached in two different ways:
If there is a detached edge, and the user begins editing a node (e.g. with Ctrl+Click).Fixed in #6991.Additionally, there is a case where one action will connect an edge and begin a (conflicting) expression edit:
Expected behaviour
I think this "multitasking" is probably not desirable--the user probably never intends to edit an edge and a node expression simultaneously.
Proposed changes:
How we can reproduce it?
No response
Screenshots or screencasts
Logs
No response
Enso Version
develop
Browser or standalone distribution
Standalone distribution (local project)
Browser Version or standalone distribution
standalone
Operating System
Linux
Operating System Version
No response
Hardware you are using
No response