search

enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.34k stars 320 forks source link

Windows binaries should be signed with Enso not with the underlying company #7154

Open hubertp opened 1 year ago

hubertp commented 1 year ago

This is likely confusing to users (sorry for the polish version of Windows, that's the only I have at hand atm):

Screenshot from 2023-06-28 18-01-35

farmaazon commented 1 year ago

The company name should be same as at enso.org: "Enso International Inc."

wdanilo commented 1 year ago

CC @mwu-tow

mwu-tow commented 1 year ago

We have no control over this name when building, it is the name of the company that requested the code signing certificate and it is part of the certificate. The only way to change is to use a different company / rename the company and reapply for the certificate.

wdanilo commented 1 year ago

We should do this (rename the company or request it from Enso International). CC @sylwiabr and @xvcgreg

xvcgreg commented 1 year ago

According to GH Docs (https://docs.github.com/en/organizations/managing-organization-settings/renaming-an-organization) it can be changed here: https://github.com/organizations/enso-org/settings/profile

I do not have sufficient admin rights for that. @sylwiabr can you look into this?

GitHub Docs
Renaming an organization - GitHub Docs
If your project or company has changed names, you can update the name of your organization to match.
GitHub
Build software better, together
GitHub is where people build software. More than 100 million people use GitHub to discover, fork, and contribute to over 330 million projects.
sylwiabr commented 1 year ago

@xvcgreg the problem is not in GH but in the certificate itself. When we will be setting up a new certificate we have to remember to use Enso Inc. name and data.