search

enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.31k stars 318 forks source link

Remove backgrounds from `.scene` and `#root` #7643

Closed somebody1234 closed 4 months ago

somebody1234 commented 10 months ago

The dashboard and IDE should have the same background. In order to do this, the solid color backgrounds currently set on .scene and #root should be removed.

somebody1234 commented 10 months ago

This is where .scene seems to have its background set: https://github.com/enso-org/enso/blob/4203a6e7781b7bb94f97318ee1b3d5a663fdd533/lib/rust/ensogl/core/src/display/scene.rs#L1039-L1045

And here for #root: https://github.com/enso-org/enso/blob/4203a6e7781b7bb94f97318ee1b3d5a663fdd533/lib/rust/ensogl/pack/js/src/runner/index.ts#L262-L268

vitvakatu commented 10 months ago

Remember that we might rely on the application.background property from the stylesheet when calculating colors for other GUI elements. All these usages must be reviewed.

For a little context, the #root element background was set to white by me to ensure we notice when something goes wrong with application.background handling. So I think it can be safely removed.

farmaazon commented 4 months ago

No longer relevant in new GUI.