search

enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.34k stars 320 forks source link

Each subsequent instance of Enso asks me to log in #7645

Open xvcgreg opened 1 year ago

xvcgreg commented 1 year ago

Discord username

No response

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

Is this a regression?

What issue are you facing?

https://github.com/enso-org/enso/assets/108271897/26eca88a-1107-47fa-a5e8-0bd9a6e8bf0a

Expected behaviour

once logged in - Enso remembers I'm autentifficated

How we can reproduce it?

No response

Screenshots or screencasts

No response

Logs

No response

Enso Version

2023.8.23 nightly

Browser or standalone distribution

Standalone distribution (local project)

Browser Version or standalone distribution

standalone

Operating System

Windows

Operating System Version

Win11pro 22H2 22621.2134

Hardware you are using

12th Gen Intel(R) Core(TM) i9-12900HK / RTX3060 Laptop / Nvidia Drivers 531.68

somebody1234 commented 1 year ago

@xvcgreg i think you posted this before the video finished uploading btw.

as for this issue... i think it might be possible to have just one electron instance, and have new instances of the app just open new windows - that way Enso doesn't have to spawn more than one Project Manager. does anyone have any thoughts? is there a situation where this doesn't work, or where this is not desirable?

xvcgreg commented 1 year ago

@somebody1234 thanks. fixed

somebody1234 commented 1 year ago

@xvcgreg Potential fix at #7648. It seems to work for me on Linux, but Linux has neither file handling nor URL handling, so I can't guarantee that those aren't currently broken in that branch (e.g. if authentication URLs open in the wrong window, or if double clicking a file does the wrong thing)

hubertp commented 1 year ago

Based on the discussion, I'm adding dashboard label.

somebody1234 commented 1 year ago

It might be g-electron, depending on the cause of this issue

jdunkerley commented 12 months ago

We should at least for now stop multiple instances of electron running. We can revisit at a later date when we support different port numbers etc for project manager.

somebody1234 commented 12 months ago

@jdunkerley note that we do now support different port numbers for the PM

somebody1234 commented 9 months ago

putting on hold as i don't think this is actionable currently?

i wonder if the multi-user that's supported by GUI2 would be useful for this - although, it would mean that the same yjs instance needs to be integrated with both React and Vue