enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.34k stars 320 forks source link

Unexpected result of failed folder name change - CB opened and node created in running project #7664

Closed xvcgreg closed 6 months ago

xvcgreg commented 1 year ago

Discord username

No response

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

Is this a regression?

What issue are you facing?

I was working on test cloud project. I have left it open and switched back to the dashboard. Created a folder there. Upon rename I have hit enter confirm the rename - got error: image I retried and this time used the button to confirm name change (got same errror, folder hasn't had it's name changed). The name I was trying to use was "Enso Test". I have tested couple of other things (dragging and dropping, sorting, etc). When I have got back to the still opened project I was welcomed with CB opened: image

https://github.com/enso-org/enso/assets/108271897/9bc5ea7d-b1d2-4ff8-87a6-98dec31f2d33

Expected behaviour

Project that is left open is not accessed by the actions from dashboard.

How we can reproduce it?

Pressing enter in dashboard opens CB in the running project Typing again the new name for the folder is captured by the opened CB

Screenshots or screencasts

No response

Logs

No response

Enso Version

2023.8.25 nightly

Browser or standalone distribution

Standalone distribution (cloud project)

Browser Version or standalone distribution

standalone

Operating System

Windows

Operating System Version

Win11pro 22H2 22621.2134

Hardware you are using

12th Gen Intel(R) Core(TM) i9-12900HK / RTX3060 Laptop / Nvidia Drivers 537.13

farmaazon commented 1 year ago

Reproduced. Seems like the keyboard events are handled by both dashboard and opened project (despite the latter is not visible).

I will check, but I think this is a regression, as I tested this scenario some time ago.

farmaazon commented 6 months ago

I cannot make folder-rename error anymore - all names are accepted :) But my guess is that the problem was with focus, and it did not depend on error or not - and that is fixed in GUI2