Closed xvcgreg closed 7 months ago
From what I have investigated somehow during rename of project Enso created second one. Firstly I have created New Project 16 and then renamed it to "101 - Navigation" - somehow I have now 2 folders inside projects folder:
both created the same time but one (the renamed to 101 - Navigation - with folder name "New_Project_16") is a fresh project (with just the starting node) and one not renamed with all the nodes I have created (folder name: "New_Project_16_1").
Renamed project throws the above-mentioned panic, the not renamed opens w/o a problem.
https://github.com/enso-org/enso/assets/108271897/b567ab4f-bbb2-4d2d-9638-df22b41cb431
Just zipped project: New_Project_16.zip
We have the following lines in our code:
fn from_str(s: &str) -> Result<Self, Self::Err> {
// While in theory it is possible that Uuid string representation is a valid project name,
// in practice it is very unlikely. Additionally, Uuid representation used by us is
// hyphenated, which will never be the case for project name. This, we can use this as a
// heuristic to determine whether the provided string is a project name or a project ID.
if s.contains('-') {
let id = Uuid::from_str(s)
.context(format!("Failed to parse project ID from string: '{s}'."))?;
Ok(ProjectToOpen::Id(id))
} else {
Ok(ProjectToOpen::Name(ProjectName::new_unchecked(s)))
}
}
And the comment is no longer valid – ProjectName
can contain hyphens now. We need to review our logic of parsing web arguments in GUI.
Issues with renaming and duplicated project seem to be not connected with that, though.
Created a separate task for duplicated project problem: https://github.com/enso-org/enso/issues/7705
No longer reproducible in GUI2
Discord username
No response
What type of issue is this?
Transient – Occurring only once
Is this issue blocking you from using Enso?
Is this a regression?
What issue are you facing?
I have created new project, and renamed it while opening. Worked a bit on it - then I have stopped the project by returning to the dashboard and stopping it via stop button. When I launched it again (w/o exiting Enso) I got panic in the log and project didn't load (even the BG wasn't loaded):
Expected behaviour
project opening w/o panic
How we can reproduce it?
No response
Screenshots or screencasts
No response
Logs
No response
Enso Version
2023.8.28 nightly
Browser or standalone distribution
Standalone distribution (local project)
Browser Version or standalone distribution
standalone
Operating System
Windows
Operating System Version
Win11pro 22H2 22621.2134
Hardware you are using
12th Gen Intel(R) Core(TM) i9-12900HK / RTX3060 Laptop / Nvidia Drivers 537.13