search

enso-org / enso

Enso Analytics is a self-service data prep and analysis platform designed for data teams.
https://ensoanalytics.com
Apache License 2.0
7.38k stars 323 forks source link

Inconsistent type reported by Meta for `[]` #8255

Closed radeusgd closed 11 months ago

radeusgd commented 1 year ago

As raised on Discord, we can see that there is inconsistency between the types reported by various Meta methods for the value [] (and any other vector for that matter):

Actual behaviour

> Meta.get_qualified_type_name []
>>> Standard.Base.Data.Vector.Vector
> Meta.get_simple_type_name []
>>> Array
> Meta.get_qualified_type_name [].to_array
>>> Standard.Base.Data.Array.Array
> Meta.get_simple_type_name [].to_array
>>> Array

We can see that the Vector type is still characterized as Array by the get_simple_type_name. It seems like both methods should be consistent - so I assume that we most likely want:

Expected behaviour

> Meta.get_qualified_type_name []
>>> Standard.Base.Data.Vector.Vector
> Meta.get_simple_type_name []
>>> Vector
JaroslavTulach commented 11 months ago

The get_simple_type_name is (probably due to historical reasons) a completely different implementation that is not using the TypeOf...Node as the get_qualified_type_name does. Probably time to rewrite the simple version to delegate to fully qualified name and shorten it - where possible.

enso-bot[bot] commented 11 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2023-12-03):

Progress: - analyzing "type names": https://github.com/enso-org/enso/issues/8255

Next Day: Bugfix "type names"

Discord
Discord - A New Way to Chat with Friends & Communities
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
enso-bot[bot] commented 11 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2023-12-04):

Progress: - Meta.get_simple_type_name

Next Day: Bugfix "type names"

Discord
Discord - A New Way to Chat with Friends & Communities
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
enso-bot[bot] commented 11 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2023-12-05):

Progress: - AoC: https://discord.com/channels/401396655599124480/1181479168400171098/1181516808495312896

Next Day: Bugfix something

Discord
Discord - A New Way to Chat with Friends & Communities
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
enso-bot[bot] commented 11 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2023-12-06):

Progress: - merged: https://github.com/enso-org/enso/pull/8448

Next Day: Bugfix something

Day 6 - Advent of Code 2023