search

enso-org / enso

Enso Analytics is a self-service data prep and analysis platform designed for data teams.
https://ensoanalytics.com
Apache License 2.0
7.38k stars 323 forks source link

Reorder nodes after connecting. #8494

Closed farmaazon closed 10 months ago

farmaazon commented 11 months ago

After #8367

After connecting node, we must sure that for each connection, the target node will be after the source node in the code (unless there is a cycle)

somebody1234 commented 11 months ago

i think this would benefit from waiting for AST edits first

vitvakatu commented 11 months ago

Also keep in mind that the cycle can involve arbitrary number of nodes:

a = … c …
b = … a …
c = … b …
enso-bot[bot] commented 10 months ago

Paweł Grabarz reports a new STANDUP for yesterday (2024-01-11):

Progress: Added tests, fixed edits from initial empty function state and when deleting multiple nodes at once. It should be finished by 2024-01-19.

enso-bot[bot] commented 10 months ago

Paweł Grabarz reports a new STANDUP for yesterday (2024-01-15):

Progress: Reviewed Selection Widget: shorten entries #8727 which is now merged. Working on feedback from PR for "Reorder nodes after connecting" story It should be finished by 2024-01-19.

Next Day: Next day I will be working on the #8387 task. Finish "Reorder nodes after connecting" story. After that other GUI2 defects as found. Then back to Process for simple exporting icons from Figma.

enso-bot[bot] commented 10 months ago

Paweł Grabarz reports a new STANDUP for the provided date (2023-12-28):

Progress: Debugging AST updates, trying to understand failing widget update operations. It should be finished by 2024-01-19.

enso-bot[bot] commented 10 months ago

Paweł Grabarz reports a new STANDUP for the provided date (2024-01-03):

Progress: Started implementing node reordering. Started 360 Feedback. It should be finished by 2024-01-19.

enso-bot[bot] commented 10 months ago

Paweł Grabarz reports a new STANDUP for the provided date (2024-01-04):

Progress: Reordering blocked by incorrect AST update handling, had a meeting about AST design details. Finished 360 Feedback. It should be finished by 2024-01-19.

enso-bot[bot] commented 10 months ago

Paweł Grabarz reports a new STANDUP for the provided date (2024-01-09):

Progress: Continuing work on reordering after necessary AST manipulation fixes have landed. It should be finished by 2024-01-19.

enso-bot[bot] commented 10 months ago

Paweł Grabarz reports a new STANDUP for the provided date (2024-01-10):

Progress: Finished initial implementation and opened a PR. It should be finished by 2024-01-19.

enso-bot[bot] commented 10 months ago

Paweł Grabarz reports a new STANDUP for the provided date (2024-01-12):

Progress: Working on feedback from PR for "Reorder nodes after connecting" story It should be finished by 2024-01-19.