Closed radeusgd closed 11 months ago
Radosław Waśko reports a new STANDUP for yesterday (2023-12-20):
Progress: Pulling the PRs thru reviews and CI. Prepared the PR for handling of nulls in Vector.filter by Filter_Condition. Researched some bug within it. AoC. It should be finished by 2023-12-20.
Next Day: Next day I will be working on the #8555 task. Pick up next task. Get the PRs merged. Finish an AoC task I was trying to do.
As we can see - in
Table.filter
this works well, because all of our vectorized table operations have special handling for NULLs (Nothing
) in the columns.However,
Vector.filter
just delegates to raw predicates like.is_finite
or(<)
which are not defined forNothing
and thus fail.We should improve
Filter_Condition.to_predicate
to add special handling forNothing
to allow better filtering of vectors containing nulls.