search

enso-org / enso

Enso Analytics is a self-service data prep and analysis platform designed for data teams.
https://ensoanalytics.com
Apache License 2.0
7.36k stars 322 forks source link

Build breaks: TOML parse error at line 91, column 11 #8959

Open yurivict opened 9 months ago

yurivict commented 9 months ago

Discord username

No response

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

Is this a regression?

What issue are you facing?

While attempting to build in the FreeBSD ports framework the build fails:

error: failed to parse manifest at `/usr/ports/lang/enso/work/enso-2024.1.1-nightly.2024.2.4/Cargo.toml`

Caused by:
  TOML parse error at line 91, column 11
     |
  91 |   "rustls",
     |           ^
  expected `.`, `=`
*** Error code 101

Version: 2024.1.1-nightly.2024.2.4 rust-nightly-1.76.0.20231125 FreeBSD 14.0-STABLE

Expected behaviour

n/a

How we can reproduce it?

No response

Screenshots or screencasts

No response

Logs

No response

Enso Version

rust-nightly-1.76.0.20231125

Browser or standalone distribution

Standalone distribution (local project)

Browser Version or standalone distribution

n/a

Operating System

Other (provide the OS name in the next field, please)

Operating System Version

FreeBSD 14.0

Hardware you are using

n/a

farmaazon commented 9 months ago

The rustc version our code is supposed to be built is https://github.com/enso-org/enso/blob/develop/rust-toolchain.toml#L2 We recommend using rustup (which will read proper rustc version from above file, and download it). See this section of our contributing guideline

farmaazon commented 9 months ago

On the other hand, the issue here is strange. When I build on my Garuda with 1.76.0-nightly (37b2813a7 2023-11-24), it does not complain about Cargo.toml format. This comma also seems fine , but you can try to remove it and see what happens.

yurivict commented 9 months ago

I work on the FreeBSD port. For simple users it is much easier to run 'pkg install enso', rather than answering many questions that rustup asks and then waiting for it to build the package. The latter is simply unsustainable for simple users. We need a way to build the package from source.

farmaazon commented 9 months ago

I understand.

We plan to remove a great share of our rust code very soon (#8481). We will bump rustc nigtly version only after, as it is non-trivial in our current codebase.

farmaazon commented 5 months ago

We bumped the rust version recently to 1.79.0-nightly (eb45c8444 2024-03-17), do you still have this issue?