enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.34k stars 323 forks source link

Adding components inside a group incorrectly adds the component at the parent level #9049

Closed AdRiley closed 7 months ago

AdRiley commented 7 months ago

Create the below workflow

image

Select the middle 2 components and press CTRL-G to group them

image

Double click on Main.collapsed to enter the grouped workflow

image

Drag from the .+ 3 output port to create a new component and try to add .+ 5.

Node does not appear to get added

image

Double click on background to return to parent workflow. Node has been incorrectly added there.

image

enso-bot[bot] commented 7 months ago

Adam Obuchowicz reports a new STANDUP for yesterday (2024-02-14):

Progress: Created a fix. Discovered that the thing is hard to test in our current code. Tried some careful refactoring, but it turned out it has to be much bigger - created a task for that. Besides, did the bookclub and rearranged task to be ready for being refined tomorrow. It should be finished by 2024-02-15.

Next Day: Next day I will be working on the #8963 task. Take some next task from backlog

enso-bot[bot] commented 7 months ago

Adam Obuchowicz reports a new 🔴 DELAY for yesterday (2024-02-19):

Summary: There is 4 days delay in implementation of the Adding components inside a group incorrectly adds the component at the parent level (#9049) task. It will cause 4 days delay for the delivery of this weekly plan.

Delay Cause: Two days of sick leave

enso-bot[bot] commented 7 months ago

Adam Obuchowicz reports a new STANDUP for yesterday (2024-02-19):

Progress: Catching up after being off, planning, meetings and reviews. Merged the PR with fix for creating nodes inside functions. It should be finished by 2024-02-19.

Next Day: Next day I will be working on the #8942 task. New transient failures have arisen, I need to check them.

enso-bot[bot] commented 7 months ago

Adam Obuchowicz reports a new 🔴 DELAY for today (2024-02-20):

Summary: There is 3 days delay in implementation of the Adding components inside a group incorrectly adds the component at the parent level (#9049) task. It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: The stream of E2E failures seem to be not exthaused. But this time they caught a potential real issue in our App

enso-bot[bot] commented 7 months ago

Adam Obuchowicz reports a new STANDUP for today (2024-02-20):

Progress: When tried to reproduce locally, I found something in log what could be the cause of the issue: when quick clicking at breadcrumbs in tests, some clicks are interpreted as double clicking background. Started refactoring things to make sure no such click leaking occurs, and also unifying the way we interact with user clicks (click vs pointerdown). Still checking some issues in CB. It should be finished by 2024-02-22.

Next Day: Next day I will be working on the same task. Fix issues and make a PR.