enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.32k stars 320 forks source link

Verify downloading Enso project locally works #9176

Closed hubertp closed 3 months ago

hubertp commented 4 months ago

Part of local project manager's improvements epic.

Apparently the feature has been supported on the backend for a while but needs to be verified. Problems have been reported.

4e6 commented 4 months ago

Project manager exposes the projects/{project-id}/enso-project HTTP endpoint for downloading projects.

The Download menu entry of the projects list redirects to the /api/project-manager/projects/${asset.id}/enso-project https://github.com/enso-org/enso/blob/fecdd534b1f4256955a2c9c80da5ac80f7e4a630/app/ide-desktop/lib/dashboard/src/components/dashboard/AssetRow.tsx#L365-L368

Which is being rewritten by the Electron server to the appropriate project manager URL https://github.com/enso-org/enso/blob/fecdd534b1f4256955a2c9c80da5ac80f7e4a630/app/ide-desktop/lib/client/src/bin/server.ts#L137-L142

URL rewriting is not implemented in the dev server (when GUI started with npm run dev, and therefore the Download menu entry only works in the desktop app.

enso-bot[bot] commented 4 months ago

Dmitry Bushev reports a new STANDUP for yesterday (2024-02-27):

Progress: Finishing working on the Yjs task. Cleaned up the server implementation. Simplified the event emitter interface by re-using the event listener functions. Created the PR. Switched to the task. Investigated the library management functionality of the language server and ensured that it was covered with tests. It should be finished by 2024-02-28.

Next Day: Next day I will be working on the #9176 task. Continue working on the task

enso-bot[bot] commented 4 months ago

Dmitry Bushev reports a new STANDUP for today (2024-02-28):

Progress: Continue working on the task. Investigated the download feature of the dashboard. Found out why it does not work in the dev server. Described in the issue. It should be finished by 2024-02-28.

Next Day: Next day I will be working on the #9176 task. Continue working on the task

hubertp commented 3 months ago

So the verification bit is done. I create a follow up ticket for you @somebody1234 https://github.com/enso-org/enso/issues/9482