enso-ui / tables

Tables
MIT License
11 stars 10 forks source link

Add translation labels and datepicker #20

Closed heyner29 closed 4 years ago

aocneanu commented 4 years ago

@heyner29 lol, did you discover the internal filters? 🗡️

Please give me feedback on this, and note that it's still experimental.

heyner29 commented 4 years ago

If I like to review a little behind each commit. I found the function and wanted to test it XD At the moment it looks very cool, I understand how you say that it is still experimental, but it looks very good. At the moment the only thing I have to provide additional is that the interval of dates allows to select as a maximum date one prior to the minimum. I know it's a matter of logic as a user not to do it, but with users you don't know jejeje

image

And it has the same bug that the interval filter had when selecting the maximum day it should be 23:59:59 in order for the records of the maximum day to appear, otherwise they will not appear.

image

image

And finally, clicking to change the month or year closes the filter without being able to make the selection.

I will continue to review and try to contribute in commits or feedback