enso-ui / tables

Tables
MIT License
11 stars 10 forks source link

Changing boolean custom filters is not possible #36

Closed robbykrlos closed 2 years ago

robbykrlos commented 2 years ago

This is a bug.

Prerequisites

Description

You can simulate this on your demo site, if you put a filter on is_active on Users table, and start with the initial filter on true, but decided to change it afterwards on false, it will not work, and you cannot trigger the control to close by clicking outside.

image

robbykrlos commented 2 years ago

Problem is here:

client/node_modules/@enso-ui/tables/src/bulma/parts/top/filters/Labels.vue

v-click-outside="() => hide(index)">

going deeper here:

client/node_modules/@enso-ui/directives/src/clickOutside.js

robbykrlos commented 2 years ago

Fixed by "@enso-ui/directives@2.0.13"

https://github.com/enso-ui/directives/commit/1f7383b4a78fb53c7cae6cd6568bc595351aea30