search

enspyrco / crowdleague

Crowdsource your sports leagues.
7 stars 1 forks source link

i273: Refactor Problem class as abstract and add subclasses #284

Closed T-Davis closed 3 years ago

T-Davis commented 4 years ago

fixes #273

Refactor the error handling approach by removing the ProblemType enum and replacing it with sub-classes of Problem

nickmeinhold commented 4 years ago

I was just checking Effective Dart for the right language for subtype/subclass/whatever and found this:

https://dart.dev/guides/language/effective-dart/design#do-document-if-your-class-supports-being-extended

@T-Davis do you think we should rename Problem to ProblemBase? My vote would be a 'yes' but I don't have a strong opinion.

T-Davis commented 4 years ago

@nickmeinhold, nice find! I completely agree, pushing a new commit now

nickmeinhold commented 4 years ago

I got to thinking about the types/groupings of Problems we might use. I started a conversation:

3. Error Handling - What types/groupings of Problems should we have?