entangled / entangled.py

Python port of Entangled
Apache License 2.0
33 stars 7 forks source link

can rich be a mandatory dependency? #7

Closed RonnyPfannschmidt closed 11 months ago

RonnyPfannschmidt commented 1 year ago

while hacking around a bit more to warm up to the codebase i created https://github.com/RonnyPfannschmidt/entangled.py/pull/1/commits/120aea99314cccaa59969a62bf7f4f6d431e2a1a to enhance the file tree printing a little

seeing the code and the related code made me think that having rich always doesnt seem too bad as a dependency

im happy to submit a mr with the changes to go all in on rich if that idea sails

jhidding commented 1 year ago

rich depends on ipywidgets, which pulls in everything and the kitchen sink. For projects that do not involve Python otherwise this is a big ask.

RonnyPfannschmidt commented 1 year ago

good point, i'll check with its maintainers if something about that can be done

RonnyPfannschmidt commented 1 year ago

i believe that until opt-out extras land this may have to sit

willmcgugan commented 1 year ago

Rich doesn't depend on ipywidgets unless you request jupyter extras.

jhidding commented 1 year ago

In that case I don't object