search

entdark / jaMME

Jedi Academy Movie Maker's Edition
GNU General Public License v2.0
16 stars 15 forks source link

Remove annoying warning in console when server tries to force cvars #11

Closed Avygeil closed 8 years ago

Avygeil commented 8 years ago

It is good design from the server side, jaMME even purposefully accepts setting the "sex" cvar to work with base_enhanced. The server mod tries to force the cvar only once when possible, but sometimes it can't (when it waits for the cvar to change and it doesn't change if the client doesn't allow it for example), which rains warnings in console. It's fine that jaMME disallows changes, but this warning is more of a developer thing, so I changed it to DPrintf. Not to mention many other server mods spam cvar forcing a lot more than base_enhanced, such servers are unplayable with this warning. From a UI perspective, even if this warning would happen only once, it is very annoying and the normal player doesn't care about it.

ensiform commented 8 years ago

Why would the server need to enforce the sex cvar? The protection here is for malicious intentions as such that is why it's there in the first place. Like redirecting fs_cvars of clients or activeAction etc.

Avygeil commented 8 years ago

Sure the protection is very good, but some old, unupdated server mods still force too many cvars: I don't need to see warnings every time my userinfo changes on these servers.

As for setting sex, it is used by base_enhanced for tracking users across restarts. OpenJK already sends a theorically consistent guid, so it can just use it, but basejka and jaMME don't.