search

ente-io / ente

Fully open source, End to End Encrypted alternative to Google Photos and Apple Photos
https://ente.io
GNU Affero General Public License v3.0
16.31k stars 844 forks source link

Desktop: Do not ignore duplicate filenames #2143

Open philips opened 5 months ago

philips commented 5 months ago

Description

I tried out Takeout upload and the progress modal said that Ente Desktop ignored files with duplicate filenames. THIS IS BAD! I have lots of images with duplicate filenames due to reseting the counter on my various digital cameras over the years.

Version

1.7.0

What product are you using?

Ente Photos

What platform are you using?

Desktop - macOS

mnvr commented 5 months ago

It will only ignore duplicates if they have the exact same content (we compare the file hash). Likely you resumed your upload which is why you're seeing this (the second time you are uploading, the uploader compares the files against the existing files, and since it finds a file with the same hash, it ignores the dup).

scag1io commented 5 months ago

I'll write my experience here, since I canceled my subscription because of the lack of this feature. I was migrating from Google Photos. I use mostly iOS, so my recent pics are .HEIC.

  1. On the "Google Takeout" I downloaded all my data
  2. I uploaded all the Takeout photos using the Ente macOS app
  3. I installed the Ente iOS app and let it backup all the photos on my phone

As a result, all the memories on Ente that were still on the phone were doubled: Google Photo, when backing up, slightly compresses the .HEIC images, and the hash calculation is obviously not enough. For Ente, they two different pictures with the same name. I hope that's clear, in case I can provide two example pictures.