ente-io / ente

Fully open source, End to End Encrypted alternative to Google Photos and Apple Photos
https://ente.io
GNU Affero General Public License v3.0
14.52k stars 748 forks source link

Ripple effect on button Upload #2921

Closed Tuscann closed 3 weeks ago

Tuscann commented 3 weeks ago

Description

  1. Open desktop app
  2. Click button Upoad
  3. Click add Folder
  4. Click add File
  5. Click Google takeout
  6. Click x
  7. Check state of button Upload

Broken position image

Normal position image

Version

1.7.3

What product are you using?

Ente Photos

What platform are you using?

Desktop - Windows

mnvr commented 3 weeks ago

You need to stop opening these issues. You've opened tens of issues since yesterday night, and at this point it is coming off as spam. I assume you're trying to help, but whatever you're doing is not helping.

Tuscann commented 3 weeks ago

You have plenty of small problems to fix ! @mnvr

mnvr commented 3 weeks ago

Again, I'm assuming good intent, and that you're genuinely trying to help. I'm trying to tell you opening issues about various nits is not helping.

e.g. the "strange look" you see here is a ripple effect provided by MUI, the library we use for our UI components. I also don't like the ripple effect, but before disabling it we need to ensure we give some other indication of the hover state. This is something I've discussed and planned, and we'll do over the longer term, but opening an issue about each hover button state is not being useful. Or opening issues about grammar ("they'd" is correct, btw). Or folder organization.

Tuscann commented 3 weeks ago

You are write for they'd.

  1. Can you write with more simple words with full version they had not short version they'd. @mnvr
  2. I am only giving my opinion for UI. I have only one ticket for hover button. I do not known your plans for ripple effect provided by MUI, the library we use for our UI components
  3. For folder organization my bugs are small fixes.
vishnukvmd commented 3 weeks ago

Closing, since we do not intend to fix the behavior of these buttons right now.