search

ente-io / ente

Fully open source, End to End Encrypted alternative to Google Photos and Apple Photos
https://ente.io
GNU Affero General Public License v3.0
15.03k stars 775 forks source link

[Web] Have the Escape key clear the search #479

Open bjherbison opened 7 months ago

bjherbison commented 7 months ago

Is your feature request related to a problem? Please describe. In many interfaces pressing Escape clears something recently set. In web browsers and many other applications Escape clears a search string. Since that is a common function of Escape I'm frustrated when Escape handling isn't implemented by an application or web page.

Describe the solution you'd like When the Escape (Esc) is pressed on https://auth.ente.io/auth clear the search string and set focus to the search field.

lokeshsingh3721 commented 7 months ago

I would love to work on this issue . Can you please assign me this issue.

aakankshabhende commented 7 months ago

@mnvr I would like to work on this issue. Could you please assign me this?

Is this issue intended for below search bar?

image
bjherbison commented 7 months ago

@mnvr I would like to work on this issue. Could you please assign me this?

Is this issue intended for below search bar?

image

I was intending the comment for https://auth.ente.io/auth but I didn't really specify that. It would apply for any search bar in any web application.

mnvr commented 7 months ago

Hey @aakankshabhende, thank you for helping out! As @bjherbison mentioned, this behaviour perhaps makes sense for most (all?) search bars, so we can add it to both auth and photos search bars. But if it is simpler for you then we can start by adding it to auth first, just to reduce the scope of changes.

klaas0 commented 3 months ago

It would also be cool to focus the search bar with key combination (CTRL + F)

daeh commented 3 months ago

Adding support for escape to exit search in MacOS Desktop app (so that it's easy to see the tags). And for cmd-F to activate the search.

SlimJim192 commented 1 week ago

It would also be cool to focus the search bar with key combination (CTRL + F)

Yep - perhaps even just default to search if window focused and you start typing.. What else could you be trying to do.

I just want to open the app, type what I want, and only use the mouse to grab the code and leave. No back and forth.

klaas0 commented 1 week ago

It would also be cool to focus the search bar with key combination (CTRL + F)

Yep - perhaps even just default to search if window focused and you start typing.. What else could you be trying to do.

I just want to open the app, type what I want, and only use the mouse to grab the code and leave. No back and forth.

Well there is actually an option for that. Settings -> General -> Focus search on app start image

bjherbison commented 1 week ago

I don't see any Settings option on the web page.

Focus on the web page starts in the search, but once you click to get a code focus is off the text box. That's why I opened this issue and #478 .

klaas0 commented 1 week ago

I don't see any Settings option on the web page.

Focus on the web page starts in the search, but once you click to get a code focus is off the text box. That's why I opened this issue and #478 .

I see, well the setting are only available in the app. You can download the app for windows with this link. Other installers are available on their website

I would highly recommend the app, it feels very snappy!

bjherbison commented 1 week ago

I gave up Windows over a decade ago. The link for Linux download goes to a page with no download option. And once you figure out what to click after that (many links are underlined in the traditional web style, but what you need to click isn't) the installer doesn't work. Once that is fixed I might try it, but I like it in a web page.