search

ente-io / ente

Fully open source, End to End Encrypted alternative to Google Photos and Apple Photos
https://ente.io
GNU Affero General Public License v3.0
11.32k stars 631 forks source link

Allow adding photos in Uncategorized to shared album #604

Open ajsteele opened 11 months ago

ajsteele commented 11 months ago

I created a family account with me and someone else and then we shared folders to collaborate on (rather than just view). However, it doesn't seem to be possible for us to add photos to one-another's albums. On some platforms (Windows PC, iOS), folders that were created and then shared with you seem to simply not appear as an option to add to; on others (Android) the folders do appear when you eg try to add a photo through the ‘share’ dialogue from another app, but we get the message ‘Can not upload to albums owned by others’.

I’m not sure if this is specific to family members as I’ve not tested it with an unconnected account.

Any help much appreciated!

abhinavkgrd commented 11 months ago

@ajsteele, So the desktop app didn't have support for collaboration, until just now 😄 .

Seems like your lucky day 😁 , we have just released an update, adding support to add photos to the collab album and manage collab.

You can wait for the app to auto-update (for dmg, exe, or AppImage), or get it directly from GitHub releases (https://github.com/ente-io/photos-desktop/releases/tag/v1.6.36).

please let us know if you are still facing the issue.

ajsteele commented 11 months ago

Haha, quick work!

I'm afraid I still have the issue after updating though: if I drag a photo from Explorer onto Ente, the list of albums I can add to shows my albums, but doesn't include the one shared with me. And I assume the issue remains on the mobile versions too?

abhinavkgrd commented 11 months ago

Ahh, The issue happening here is

Only uploaded photos can be added to shared albums currently. So if a user wants to adds a new photo to a shared album, we expect them to first upload that photo to one of their albums, and then add to the shared album.

https://github.com/ente-io/ente/issues/930

We already have it in our roadmap and will get it done soon.

ajsteele commented 11 months ago

That does seem to be the same problem!

However, I have an issue with that too—I had actually tried it, and on both desktop and Android, the shared album doesn't seem to appear when I try to move a photo from Uncategorized?

abhinavkgrd commented 11 months ago

Ah, It seems like we have hit another edge case 😬

Files can only be moved from uncategorized currently. But moving to a shared album is not allowed 🥲. So, you would have to move it to one of your own albums first, and then try to add it to the shared album.

Sorry for the inconvenience!! Will get this fixed soon.

ajsteele commented 11 months ago

Ah got it! I’d not grokked the difference between ‘move’ and ‘add’ as I’d not tried this from albums other than uncategorized…