search

entechlog / dbt-snow-mask

This repository contains source code for dbt package dbt_snow_mask.
https://hub.getdbt.com/entechlog/dbt_snow_mask/latest/
GNU General Public License v3.0
60 stars 25 forks source link

added oneresource functionality #41

Closed Chobsz closed 1 year ago

Chobsz commented 2 years ago

To enable masking and unmasking of single models or sources, functionality has been added as an optional parameter [resource_name]. The changeset should be backwards compatible.

I found the commands for unmasking too broad, affecting more resources than needed when applying of unapplying them. I introduced this optional parameter, to quickly mask or unmask just 1 resource (sourcename from jamlfile) or nodename/foldername for model. The old way, all sources would be unmasked during the post-hook or on-run-end, leaving unnecisary data exposed.

dweaver33 commented 2 years ago

@entechlog, can you review and merge this?

entechlog commented 2 years ago

@Chobsz , Possible to do a rebase and test the changes to ensure its accounting for the feature ? Please add apply and unapply test results into this PR ?

Chobsz commented 2 years ago

@entechlog , Considering i'm far from a dedicated coder, i don't really know what you are asking me to do. I'm noticing the merge conflict, i could resolve this and try to test the result at my customers Dev infrastructure. i'll ask google what "add apply and unapply testresults" in Github means. :)

entechlog commented 2 years ago

@Chobsz

https://github.com/entechlog/dbt-snow-mask#how-to-apply-masking-policy-

https://github.com/entechlog/dbt-snow-mask#how-to-remove-masking-policy-

Chobsz commented 1 year ago

Right, today and tomorrow got some time to do the tests. i'll upgrade to 0.2.3 and retest my changes. does that mean that i have to create a new PR? Because mine was based on v0.2.0.

Chobsz commented 1 year ago

Really struggling with this darned Git push pull pr stuff.. dropping this Pr and creating a new one off of main..