search

entelecheia / thematos

A HyFI plugin for Topic Modeling
https://thematos.entelecheia.ai/
MIT License
1 stars 1 forks source link

0.2.3.dev #40

Closed entelecheia closed 1 year ago

entelecheia commented 1 year ago

Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 48.88% and project coverage change: -49.79% :warning:

Comparison is base (a6b4199) 100.00% compared to head (498a8c8) 50.21%. Report is 3 commits behind head on main.

:exclamation: Current head 498a8c8 differs from pull request most recent head bc79b8a. Consider uploading reports for the commit bc79b8a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #40 +/- ## ============================================ - Coverage 100.00% 50.21% -49.79% ============================================ Files 3 13 +10 Lines 13 462 +449 ============================================ + Hits 13 232 +219 - Misses 0 230 +230 ``` | [Files Changed](https://app.codecov.io/gh/entelecheia/thematos/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee) | Coverage Δ | | |---|---|---| | [src/thematos/tasks/\_\_init\_\_.py](https://app.codecov.io/gh/entelecheia/thematos/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL3Rhc2tzL19faW5pdF9fLnB5) | `0.00% <0.00%> (ø)` | | | [src/thematos/tasks/topic.py](https://app.codecov.io/gh/entelecheia/thematos/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL3Rhc2tzL3RvcGljLnB5) | `0.00% <0.00%> (ø)` | | | [src/thematos/models/lda.py](https://app.codecov.io/gh/entelecheia/thematos/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL21vZGVscy9sZGEucHk=) | `42.85% <42.85%> (ø)` | | | [src/thematos/models/base.py](https://app.codecov.io/gh/entelecheia/thematos/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL21vZGVscy9iYXNlLnB5) | `43.01% <43.01%> (ø)` | | | [src/thematos/datasets/corpus.py](https://app.codecov.io/gh/entelecheia/thematos/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL2RhdGFzZXRzL2NvcnB1cy5weQ==) | `49.38% <49.38%> (ø)` | | | [src/thematos/models/prior.py](https://app.codecov.io/gh/entelecheia/thematos/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL21vZGVscy9wcmlvci5weQ==) | `61.66% <61.66%> (ø)` | | | [src/thematos/\_version.py](https://app.codecov.io/gh/entelecheia/thematos/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL192ZXJzaW9uLnB5) | `100.00% <100.00%> (ø)` | | | [src/thematos/datasets/\_\_init\_\_.py](https://app.codecov.io/gh/entelecheia/thematos/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL2RhdGFzZXRzL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [src/thematos/models/\_\_init\_\_.py](https://app.codecov.io/gh/entelecheia/thematos/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL21vZGVscy9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [src/thematos/models/config.py](https://app.codecov.io/gh/entelecheia/thematos/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL21vZGVscy9jb25maWcucHk=) | `100.00% <100.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/entelecheia/thematos/pull/40?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pull-request-quantifier-deprecated[bot] commented 1 year ago

This PR has 1237 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

``` Label : Extra Large Size : +1234 -3 Percentile : 100% Total files changed: 24 Change summary by file extension: .envrc : +6 -2 .toml : +5 -1 .yaml : +94 -0 .py : +553 -0 .ipynb : +576 -0 ``` > Change counts above are quantified counts, based on the [PullRequestQuantifier customizations](https://github.com/microsoft/PullRequestQuantifier/blob/main/docs/prquantifier-yaml.md).

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean: - Fast and predictable releases to production: - Optimal size changes are more likely to be reviewed faster with fewer iterations. - Similarity in low PR complexity drives similar review times. - Review quality is likely higher as complexity is lower: - Bugs are more likely to be detected. - Code inconsistencies are more likely to be detected. - Knowledge sharing is improved within the participants: - Small portions can be assimilated better. - Better engineering practices are exercised: - Solving big problems by dividing them in well contained, smaller problems. - Exercising separation of concerns within the code changes. #### What can I do to optimize my changes - Use the PullRequestQuantifier to quantify your PR accurately - Create a context profile for your repo using the [context generator](https://github.com/microsoft/PullRequestQuantifier/releases) - Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the `Excluded` section from your `prquantifier.yaml` context profile. - Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your `prquantifier.yaml` context profile. - Only use the labels that matter to you, [see context specification](./docs/prquantifier-yaml.md) to customize your `prquantifier.yaml` context profile. - Change your engineering behaviors - For PRs that fall outside of the desired spectrum, review the details and check if: - Your PR could be split in smaller, self-contained PRs instead - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR). #### How to interpret the change counts in git diff output - One line was added: `+1 -0` - One line was deleted: `+0 -1` - One line was modified: `+1 -1` (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion) - Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.

Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.