entelecheia / thematos

A HyFI plugin for Topic Modeling
https://thematos.entelecheia.ai/
MIT License
1 stars 1 forks source link

0.5.dev #43

Closed entelecheia closed 1 year ago

entelecheia commented 1 year ago

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 23.63% and project coverage change: -1.52% :warning:

Comparison is base (7289303) 47.99% compared to head (56cff6b) 46.47%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #43 +/- ## ========================================== - Coverage 47.99% 46.47% -1.52% ========================================== Files 14 14 Lines 498 525 +27 ========================================== + Hits 239 244 +5 - Misses 259 281 +22 ``` | [Files Changed](https://app.codecov.io/gh/entelecheia/thematos/pull/43?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee) | Coverage Δ | | |---|---|---| | [src/thematos/models/lda.py](https://app.codecov.io/gh/entelecheia/thematos/pull/43?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL21vZGVscy9sZGEucHk=) | `38.09% <0.00%> (ø)` | | | [src/thematos/runners/\_\_init\_\_.py](https://app.codecov.io/gh/entelecheia/thematos/pull/43?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL3J1bm5lcnMvX19pbml0X18ucHk=) | `0.00% <0.00%> (ø)` | | | [src/thematos/runners/config.py](https://app.codecov.io/gh/entelecheia/thematos/pull/43?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL3J1bm5lcnMvY29uZmlnLnB5) | `0.00% <0.00%> (ø)` | | | [src/thematos/runners/topic.py](https://app.codecov.io/gh/entelecheia/thematos/pull/43?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL3J1bm5lcnMvdG9waWMucHk=) | `0.00% <0.00%> (ø)` | | | [src/thematos/models/base.py](https://app.codecov.io/gh/entelecheia/thematos/pull/43?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL21vZGVscy9iYXNlLnB5) | `42.51% <58.82%> (+0.80%)` | :arrow_up: | | [src/thematos/\_version.py](https://app.codecov.io/gh/entelecheia/thematos/pull/43?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL192ZXJzaW9uLnB5) | `100.00% <100.00%> (ø)` | | | [src/thematos/models/types.py](https://app.codecov.io/gh/entelecheia/thematos/pull/43?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Young+Joon+Lee#diff-c3JjL3RoZW1hdG9zL21vZGVscy90eXBlcy5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pull-request-quantifier-deprecated[bot] commented 1 year ago

This PR has 126 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

``` Label : Medium Size : +86 -40 Percentile : 45.2% Total files changed: 8 Change summary by file extension: .yaml : +2 -2 .py : +84 -38 ``` > Change counts above are quantified counts, based on the [PullRequestQuantifier customizations](https://github.com/microsoft/PullRequestQuantifier/blob/main/docs/prquantifier-yaml.md).

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean: - Fast and predictable releases to production: - Optimal size changes are more likely to be reviewed faster with fewer iterations. - Similarity in low PR complexity drives similar review times. - Review quality is likely higher as complexity is lower: - Bugs are more likely to be detected. - Code inconsistencies are more likely to be detected. - Knowledge sharing is improved within the participants: - Small portions can be assimilated better. - Better engineering practices are exercised: - Solving big problems by dividing them in well contained, smaller problems. - Exercising separation of concerns within the code changes. #### What can I do to optimize my changes - Use the PullRequestQuantifier to quantify your PR accurately - Create a context profile for your repo using the [context generator](https://github.com/microsoft/PullRequestQuantifier/releases) - Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the `Excluded` section from your `prquantifier.yaml` context profile. - Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your `prquantifier.yaml` context profile. - Only use the labels that matter to you, [see context specification](./docs/prquantifier-yaml.md) to customize your `prquantifier.yaml` context profile. - Change your engineering behaviors - For PRs that fall outside of the desired spectrum, review the details and check if: - Your PR could be split in smaller, self-contained PRs instead - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR). #### How to interpret the change counts in git diff output - One line was added: `+1 -0` - One line was deleted: `+0 -1` - One line was modified: `+1 -1` (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion) - Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.


Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.