search

enten / udk

Universal Development Kit: Webpack extension which improves universal application development. - THE UDK PROJECT SUPPORT IS CURRENTLY SUSPENDED.
MIT License
29 stars 7 forks source link

publish release v1.1.0 on NPM #10

Closed qdouble closed 5 years ago

qdouble commented 5 years ago

Hello, I'm looking to use the latest release, but only 1.1.0-rc.0 is on npm

enten commented 5 years ago

@qdouble Sorry for delay (it was stucked on my packages registry): udk v1.1.0 is now availabled on npm.

Can you try to install the new version of tell if every works as you expected?

Just for information: what is your usage of udk? Angular Universal? I used udk v1.1.0 to refactor the angular universal starter kit to provide a better developper experience.

qdouble commented 5 years ago

@enten hey, Thanks for the update. I'm using it for Angular Universal.

When I try to add it to my existing project that I had the previous version running in (based on the Universal Starter repo that was using it)... I get:

ERROR in No NgModule metadata found for 'AppBrowserModule'.

Name: server
Date: 2019-06-16T19:58:56.084Z
Hash: 6cd5881e1c98c04ac616
Time: 14ms

ERROR in [udk] MultiCompiler
Compilation cancelled due to errors in previous compilers: browser

Any idea what I would need to change?

enten commented 5 years ago

Did you update your dependencies to angular 8?

Can you share a repo which reproduce your issue?

qdouble commented 5 years ago

It even does it with the sample app in your repo. When you build the browser or server by itself it works fine...the issue comes up with multi compilation.

On Mon, Jun 17, 2019 at 11:28 AM Steven Enten notifications@github.com wrote:

Did you update your dependencies to angular 8?

Can you share a repo which reproduce your issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/enten/udk/issues/10?email_source=notifications&email_token=ACPOY6FAB65G47GUXV6VC4DP263SXA5CNFSM4HYPCHHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3XEMI#issuecomment-502755889, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPOY6CAY2UIUABT7X56DJLP263SXANCNFSM4HYPCHHA .

enten commented 5 years ago

When you build the browser or server by itself

Can you share commands?

qdouble commented 5 years ago

If you go to the examples/angular folder and run npm run build you will get

ERROR in No NgModule metadata found for 'AppBrowserModule'.

Name: browser-es6
Date: 2019-06-17T16:47:37.235Z
Hash: 6ef1b92a716987ec1b42
Time: 2ms

ERROR in [udk] MultiCompiler
Compilation cancelled due to errors in previous compilers: browser-es5

Name: server
Date: 2019-06-17T16:47:37.236Z
Hash: 320b72189e7d6e612743
Time: 1ms

ERROR in [udk] MultiCompiler
Compilation cancelled due to errors in previous compilers: browser-es5,
browser-es6

However, if you do ng run app:browser or ng run app:server it will compile those individually. This is hurting me right now since I can't do dev builds.

On Mon, Jun 17, 2019 at 11:37 AM Steven Enten notifications@github.com wrote:

When you build the browser or server by itself Can you share commands?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/enten/udk/issues/10?email_source=notifications&email_token=ACPOY6BICA5E67QRWOOLDILP264VLA5CNFSM4HYPCHHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3X7CA#issuecomment-502759304, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPOY6GE3FY5M44LWFWMCLDP264VLANCNFSM4HYPCHHA .

enten commented 5 years ago

@qdouble

I publish udk v1.1.1 to fix some things with the angular devkit.

Can you try to clone and run this repository: https://github.com/enten/angular-universal

Angular example in udk repository isn't up to date.

qdouble commented 5 years ago

@enten Hey yeah, it's running great now. Thanks!