search

enteraname74 / SoulSearching

A music player for Android and Desktop using Compose Multiplatform.
GNU General Public License v3.0
77 stars 4 forks source link

Landscape mode have the next button much much smaller than the previous and play/pause one #15

Closed Porkepix closed 1 month ago

Porkepix commented 10 months ago

See screenshot below on the difference of size between the buttons

Screenshot ![Screenshot_20240109-140506](https://github.com/enteraname74/SoulSearching/assets/709500/408724a6-aa43-4adc-8f02-61e16b7b5064)

Device details: Xperia XZ running Android Oreo (8.0) on stock ROM.

EDIT: I'm also unsure if we should see so few or so much at the bottom as we see here.

enteraname74 commented 10 months ago

The issue should be the same as the previous one with the buttons overlapping on the cover. I will work on that when I can. For the bottom, this part should not be visible, I'm not really sure why it behaves like that on your phone, but I will work on it to find why.

enteraname74 commented 1 month ago

Landscape mode has been reworked, on the latest version of the app, to better work on all kind of screen size. I tested it with a phone similar to your Xperia XZ (Android 8.0, size 5,2''). Let met know if it works for you.

Porkepix commented 1 month ago

@enteraname74 On 0.8.0, this is "fixed", indeed the buttons have the same size, but now the whole player on landscape takes like 20% of the screen width and is centered, creating huge margins on every side of the screen.

enteraname74 commented 1 month ago

@enteraname74 On 0.8.0, this is "fixed", indeed the buttons have the same size, but now the whole player on landscape takes like 20% of the screen width and is centered, creating huge margins on every side of the screen.

Could you share a screenshot of this ? The look of the landscape mode of the player has been reworked to ensure that there are no UI glitches but it certainly needs UI enhancement

Porkepix commented 1 month ago

@enteraname74 Here you go:

Screenshot ![Screenshot_20241007-183353](https://github.com/user-attachments/assets/2361f3c8-a44a-4bc0-bfa6-d46b360969a8)

Also note the sandwich menu on the top right corner, close to the square system button, which can't be clicked at all.

EDIT: Note that some albums doesn't load their covers, such as this one. It should have one cover. It can be related to the method to read them, I already reported similar bug to other players where as they changed the read/load method to please what newer Android versions were requesting, it broke for older versions and they had to find workarounds.