enteraname74 / SoulSearching

A music player for Android and Desktop using Compose Multiplatform.
GNU General Public License v3.0
77 stars 4 forks source link

Grammar Error #7

Closed Groonir closed 1 year ago

Groonir commented 1 year ago

Would it be possible to change the "musics" to "music" as the word's plural is the same as the singular version. Also "Personalization" is written as "Personalisation" in the settings tab

Thanks a lot for making this app as i found it very useful

jsrockstaranks commented 1 year ago

Personalization is correct spelling as per American English while Personalisation is in British English, so I think both are correct.

enteraname74 commented 1 year ago

I will see which version to choose and correct spelling mistakes. This will be fixed in the next release of the application.

Thanks for using Soul Searching!

Groonir commented 1 year ago

Personalization is correct spelling as per American English while Personalisation is in British English, so I think both are correct.

Since the app does not have a language option, it probably uses the locale. I am using a British English locale which is why i have made this issue

enteraname74 commented 1 year ago

Personalization is correct spelling as per American English while Personalisation is in British English, so I think both are correct.

Since the app does not have a language option, it probably uses the locale. I am using a British English locale which is why i have made this issue

For now, Soul Searching has two supported languages, French (my primary language) and a default one which is English. The English version is used if the system doesn't use French. But it's true that, for the English version, it's not clear whether it's the Great Britain version or the American one.

Currently, I will try to stick with the American version by default because some strings that are in the app use American English. However, for the future, I will let users choose their language in the settings of the app.

Groonir commented 1 year ago

Thanks for the clarification!

enteraname74 commented 1 year ago

I fixed some grammar errors for the English version in the new release of the application. I changed the use of the word music to song, as I find it better for the application. Let me know if it's all good for you.

Groonir commented 1 year ago

Yes it is. Thanks!