enterlab / rente

Rente: Clojure, ClojureScript, Reagent (react) + Sente (web sockets). Heroku-ready!
http://enterlab.com
Eclipse Public License 1.0
57 stars 12 forks source link

Heroku #7

Closed ioRekz closed 9 years ago

ioRekz commented 9 years ago

Hi, I'm trying to deploy my app on heroku but can't manage to do it.

If I clone this repo, run the config:add command and push, this is what I get :

Am I missing something ?

luposlip commented 9 years ago

Hi Jeremy,

To be honest I didn't try the "manual" deployment after my last commit. But the "Deploy to Heroku" button works fine for me. Have you tried that?

Best, Henrik

ioRekz commented 9 years ago

Yes the button works. I don't understand what is the diff between the 2 methods. My app is on heroku only so I guess I can't use the button.

On Thu, Apr 2, 2015 at 6:03 PM, Henrik Mohr notifications@github.com wrote:

Hi Jeremy,

To be honest I didn't try the "manual" deployment after my commit. But the "Deploy to Heroku" button works for me. Have you tried that?

Best, Henrik

— Reply to this email directly or view it on GitHub https://github.com/enterlab/rente/issues/7#issuecomment-88959166.

ioRekz commented 9 years ago

I managed to run the app by adding :min-lein-version "2.5.0" to the project.clj

and using the (env :port) instead of rente-port so the server use the port provided by heroku

I'm not sure that the min version did something but heroku was using lein 1.7 so I guess it's better anyway. I can make a pull request if those change seems relevant for everybody

luposlip commented 9 years ago

These updates of min-lein-version and :port was pushed the 25th of March. Please pull or re-clone, and test again. If it works for you out of the box afterwards, I'll close this issue.