search

enterprise-contract / ec-cli

Supply chain artifact verifier and policy checker
https://enterprisecontract.dev/docs/ec-cli/
Apache License 2.0
27 stars 29 forks source link

Fix push Pipeline #1638

Closed lcarva closed 4 months ago

lcarva commented 4 months ago

Certain Task parameter names changed. The changed was applied to the pull-request Pipeline, but not to the push Pipeline. This commit syncs them.

Ref: EC-556

lcarva commented 4 months ago

Diff between pull and push Pipelines are now as expected:

7d6
<     build.appstudio.redhat.com/pull_request_number: '{{pull_request_number}}'
10c9
<     pipelinesascode.tekton.dev/on-cel-expression: event == "pull_request" && target_branch
---
>     pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch
17c16
<   name: cli-main-ci-on-pull-request
---
>   name: cli-main-ci-on-push
25,26d23
<   - name: image-expires-after
<     value: 5d
28c25
<     value: quay.io/redhat-user-workloads/rhtap-contract-tenant/ec-main-ci/cli-main-ci:on-pr-{{revision}}
---
>     value: quay.io/redhat-user-workloads/rhtap-contract-tenant/ec-main-ci/cli-main-ci:{{revision}}
37,38d33
<   - name: build-args-file
<     value: quick-build-args.conf
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.25%. Comparing base (8d0bb4e) to head (f9fa7a7).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1638/graphs/tree.svg?width=650&height=150&src=pr&token=CY5ORXJB33&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract)](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) ```diff @@ Coverage Diff @@ ## main #1638 +/- ## ========================================== + Coverage 80.70% 87.25% +6.55% ========================================== Files 64 75 +11 Lines 4705 5045 +340 ========================================== + Hits 3797 4402 +605 + Misses 908 643 -265 ``` | [Flag](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1638/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) | Coverage Δ | | |---|---|---| | [acceptance](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1638/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) | `72.71% <ø> (?)` | | | [generative](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1638/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) | `80.70% <ø> (ø)` | | | [integration](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1638/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) | `80.70% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1638/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) | `80.70% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract#carryforward-flags-in-the-pull-request-comment) to find out more. [see 41 files with indirect coverage changes](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1638/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract)