search

enterprise-contract / ec-cli

Enterprise Contract command line interface
https://enterprisecontract.dev/docs/ec-cli/main/index.html
Apache License 2.0
26 stars 25 forks source link

Big format update from lsp/gopls via LazyVim #1643

Closed simonbaird closed 2 months ago

simonbaird commented 2 months ago

It all seems pretty reasonable. Let's consider.

lcarva commented 2 months ago

Does go fmt agree?

robnester-rh commented 2 months ago

Question:

Does go fmt agree?

+1 on this. I would prefer to be in line with whatever go fmt says.

simonbaird commented 2 months ago

Am I doing it right?

$ gofmt -w .
$ git ls-files | grep '\.go$' | xargs gofmt -w
$ git diff
..nothing..
simonbaird commented 2 months ago

Not sure how to enforce this, maybe we can figure it out and make a CI format checker.

simonbaird commented 2 months ago

Revision is just a new commit message.

simonbaird commented 2 months ago

Oh I cancelled the Konflux build to save some CPU cycles, but I forgot it's a hard requirement now.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.25%. Comparing base (583b894) to head (21c8e7e). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643/graphs/tree.svg?width=650&height=150&src=pr&token=CY5ORXJB33&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract)](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) ```diff @@ Coverage Diff @@ ## main #1643 +/- ## ========================================== + Coverage 80.69% 87.25% +6.55% ========================================== Files 64 75 +11 Lines 4704 5044 +340 ========================================== + Hits 3796 4401 +605 + Misses 908 643 -265 ``` | [Flag](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) | Coverage Δ | | |---|---|---| | [acceptance](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) | `72.75% <100.00%> (?)` | | | [generative](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) | `80.69% <100.00%> (ø)` | | | [integration](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) | `80.69% <100.00%> (ø)` | | | [unit](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) | `80.69% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) | Coverage Δ | | |---|---|---| | [cmd/inspect/inspect\_policy\_data.go](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643?src=pr&el=tree&filepath=cmd%2Finspect%2Finspect_policy_data.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract#diff-Y21kL2luc3BlY3QvaW5zcGVjdF9wb2xpY3lfZGF0YS5nbw==) | `81.01% <ø> (+43.03%)` | :arrow_up: | | [cmd/root/root\_cmd.go](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643?src=pr&el=tree&filepath=cmd%2Froot%2Froot_cmd.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract#diff-Y21kL3Jvb3Qvcm9vdF9jbWQuZ28=) | `100.00% <ø> (ø)` | | | [cmd/track/track\_bundle.go](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643?src=pr&el=tree&filepath=cmd%2Ftrack%2Ftrack_bundle.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract#diff-Y21kL3RyYWNrL3RyYWNrX2J1bmRsZS5nbw==) | `95.83% <100.00%> (+1.04%)` | :arrow_up: | | [cmd/validate/definition.go](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643?src=pr&el=tree&filepath=cmd%2Fvalidate%2Fdefinition.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract#diff-Y21kL3ZhbGlkYXRlL2RlZmluaXRpb24uZ28=) | `97.53% <100.00%> (ø)` | | | [cmd/validate/image.go](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643?src=pr&el=tree&filepath=cmd%2Fvalidate%2Fimage.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract#diff-Y21kL3ZhbGlkYXRlL2ltYWdlLmdv) | `93.77% <100.00%> (+0.32%)` | :arrow_up: | | [cmd/validate/input.go](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643?src=pr&el=tree&filepath=cmd%2Fvalidate%2Finput.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract#diff-Y21kL3ZhbGlkYXRlL2lucHV0Lmdv) | `89.47% <100.00%> (+43.60%)` | :arrow_up: | | [cmd/validate/policy.go](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643?src=pr&el=tree&filepath=cmd%2Fvalidate%2Fpolicy.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract#diff-Y21kL3ZhbGlkYXRlL3BvbGljeS5nbw==) | `92.85% <100.00%> (ø)` | | | [...ation\_snapshot\_image/application\_snapshot\_image.go](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643?src=pr&el=tree&filepath=internal%2Fevaluation_target%2Fapplication_snapshot_image%2Fapplication_snapshot_image.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract#diff-aW50ZXJuYWwvZXZhbHVhdGlvbl90YXJnZXQvYXBwbGljYXRpb25fc25hcHNob3RfaW1hZ2UvYXBwbGljYXRpb25fc25hcHNob3RfaW1hZ2UuZ28=) | `77.71% <ø> (+20.57%)` | :arrow_up: | | [...nternal/evaluation\_target/definition/definition.go](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643?src=pr&el=tree&filepath=internal%2Fevaluation_target%2Fdefinition%2Fdefinition.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract#diff-aW50ZXJuYWwvZXZhbHVhdGlvbl90YXJnZXQvZGVmaW5pdGlvbi9kZWZpbml0aW9uLmdv) | `81.81% <ø> (ø)` | | | [internal/evaluation\_target/input/input.go](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643?src=pr&el=tree&filepath=internal%2Fevaluation_target%2Finput%2Finput.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract#diff-aW50ZXJuYWwvZXZhbHVhdGlvbl90YXJnZXQvaW5wdXQvaW5wdXQuZ28=) | `76.47% <ø> (ø)` | | | ... and [9 more](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract) | | ... and [25 files with indirect coverage changes](https://app.codecov.io/gh/enterprise-contract/ec-cli/pull/1643/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enterprise-contract)
simonbaird commented 2 months ago

/retest