enterprisemediawiki / HeaderFooter

Add common headers and footers to MediaWiki pages
http://www.mediawiki.org/wiki/Extension:Header_Footer
6 stars 18 forks source link

Stickyheaders composer reorg #14

Open hexmode opened 6 years ago

hexmode commented 6 years ago

This is the sticky headers, source code reorg, etc, that I sent a pull request for before.

Moved this work onto a separate branch till it gets merged.

jamesmontalvo3 commented 6 years ago

What does "Sticky Headers" mean? What does this change actually do?

hexmode commented 6 years ago

When $wgUseStickyHeaders = true (the default) js and css is added to what is served so that the older style sticky css objects are used when so that when you scroll up the header sticks around. See this demo with the newer "position: sticky" css to see an example of what this looks like (kind of). Here's a pure-css demonstration of the older way.

CSS's position: sticky is probably too new to use.

jamesmontalvo3 commented 6 years ago

Seems like sticky shouldn't be the default. People shouldn't have to change configuration just because they upgraded, unless there's good reason. Right?

hexmode commented 6 years ago

Right, shouldn't be the default.

jamesmontalvo3 commented 6 years ago

Main NS footer not rendering HTML. See example below, footer indicated by red box.

image