search

enterprisemediawiki / HeaderFooter

Add common headers and footers to MediaWiki pages
http://www.mediawiki.org/wiki/Extension:Header_Footer
6 stars 18 forks source link

Internationalisation implemented; some code clean-up #9

Closed sm8ps closed 5 years ago

sm8ps commented 9 years ago

The internationalisation works the way you had suggested. The code works well here with multiple category headers/footers in addition to namespace headers/footers.

While I was at it, I stumbled over https://www.mediawiki.org/wiki/Manual:Messages_API which says to replace calls to deprecated wfMsg-functions. Now I have two changes in this pull request but the second one is easily separated as I left the old commands there as comments.

I noticed that the second function was formatted in a different fashion than the first. So I also changed that.

Cheers! sm

jamesmontalvo3 commented 9 years ago

Sorry for the delay on this. Working several issues on other projects before I can review this further.

sm8ps commented 9 years ago

No sweat! It is working here, so I am in no hurry.

sm8ps commented 9 years ago

I just wondered if you had not forgotten about my pull-request. Sorry if this may come inconvenient; I do not mean to push.

hexmode commented 6 years ago

This looks like it has already been done separately. Right? Should this be abandoned?

jamesmontalvo3 commented 6 years ago

@hexmode done separately where?

hexmode commented 6 years ago

meh, I had merged his code and lost track of that fact.

never mind.

jamesmontalvo3 commented 6 years ago

Meaning this PR should get merged or should not?

hexmode commented 6 years ago

It should be tested first.

sm8ps commented 5 years ago

Closing as it has probably become obsolete. #26 is an identical try.