search

enterprisemediawiki / Wiretap

User pageview tracking for MediaWiki
4 stars 6 forks source link

Update SpecialWiretap.php for REL1_28 #18

Closed freephile closed 6 years ago

freephile commented 6 years ago

Fixes Issue #17 This change should be backwards compatible with REL1_27 - but I haven't tested it.

The SpecialPage, on REL1_28 with these fixes is at https://demo.qualitybox.us/w/index.php?title=Special:Wiretap&show=

freephile commented 6 years ago

And seems to be working fine here too: https://freephile.qualitybox.us/wiki/Special:Wiretap

freephile commented 6 years ago

I haven't had a chance to look into it yet, but the backwards compatible method to fix this appears to be using some Linker:link() method. I say that because the new MediaWiki\MediaWikiServices LinkRenderer is supposed to replace that, but there must still be a way of linking in REL1_27 and REL1_28 that is non-breaking. The new code was introduced in 2016 There is a long list of extensions which still appear to use Linker:link(), even if it's deprecated. https://phabricator.wikimedia.org/T149346