add ldap module - Githubissues

enterprisemediawiki / meza

Setup an enterprise MediaWiki server with simple commands

MIT License

41 stars 27 forks source link

add ldap module #1261

Closed darenwelsh closed 4 years ago

darenwelsh commented 4 years ago

Changes

add LDAP module for PHP
generically ensure PHP 5.x packages removed instead of 5.6 only

jamesmontalvo3 commented 4 years ago

Not sure why GitHub actions tests are not running, but they are a duplicate of Travis tests for exactly this reason (redundant in case on service fails).

@darenwelsh you've tested the LDAP extension on a real server, right? If so I'm good to merge.

Regarding PHP 5.6: this change is cleaner than the current code, and therefore should be included, but functionally it's unnecessary since Meza never had less than v5.6

darenwelsh commented 4 years ago

Yeah, we had LDAP on our dev server for a while. I just can't be certain that this subset of those changes that were implemented to add LDAP before are perfect.