search

enthought / apptools

Other
37 stars 24 forks source link

LogFileHandler does not support encoding #323

Closed mechworrior closed 2 months ago

mechworrior commented 1 year ago

Currently LogFileHandler does not inherit the encoding attribute from RotatingFileHandler. This is required to enable utf-8 characters in Logs.

rahulporuri commented 1 year ago

It will be good to confirm that all of the kwargs accepted by RotatingFileHandler are also accepted by the LogFileHandler and that they are passed through as necessary.

Ref https://docs.python.org/3.6/library/logging.handlers.html#rotatingfilehandler

mdickinson commented 2 months ago

This was fixed in #324.