search

enthought / apptools

Other
37 stars 24 forks source link

Tests from source failing due to incompatible setuptools #329

Closed corranwebster closed 1 year ago

corranwebster commented 1 year ago

The periodic test runs using current man branches is failing because setuptools has fixed a bug that was causing problems and so some downstream packages are asking for more recent versions; while apptools is asking for older versions.

Fix is probably to update the valid range for apptools, but might want to for upstream packages as well (Pyface is the most likely culprit, but it could also be Envisage)

mdickinson commented 1 year ago

I don't think apptools is placing any restrictions on the setuptools version. Rather, what's happening is that we're getting setuptools from EDM, and for Python 3.6, the last version of setuptools that was packaged for EDM was 41.6.0 (while for Python 3.8, EDM has 67.4.0). So for Python 3.8 there shouldn't be any issue.

So I think the fix is either to do a pip install setuptools in etstool.py (if we're doing a source install), or to drop the Python 3.6 runs for this workflow altogether. I'd favour the latter.

mdickinson commented 1 year ago

Link to failed test run: https://github.com/enthought/apptools/actions/runs/4442730775/jobs/7799249831

mdickinson commented 1 year ago

330 "fixes" this (by dropping the Python 3.6 builds).