MAINT: fix marker size type mismatch error

enthought / chaco

Chaco is a Python package for building interactive and custom 2-D plots.

http://docs.enthought.com/chaco/

Other

292 stars 99 forks source link

MAINT: fix marker size type mismatch error #859

Closed homosapien-lcy closed 1 year ago

homosapien-lcy commented 1 year ago

The ScatterPlot1D specifies marker_size = Float(4.0) while the downstream render_markers function is supposed to handle both single numeric data and arrays. This PR changes this.

Address #846

homosapien-lcy commented 1 year ago

close issue #846

dpinte commented 1 year ago

@homosapien-lcy as next step, we discussed:

[x] add a test case reproducing the upstream issue, that should surface the problem that @mdickinson has highlighted with the way you use the Array trait
[x] fix the current version of the code and make sure the test pass
[x] add tests cases for the various other use case you cover in the new Union (and verify that as Mark suggests, it's not needed to add the Int trait in the Union)

homosapien-lcy commented 1 year ago

With Corran's comments, after discussing with Didrik, we think:

1 the "error" that the user reported in #846 is actually the expected behavior of the test, thus there is no need to change the scatterplot class to enable different types of inputs 2 the confusion comes from the fact that in chaco/examples/demo/basic/scatter_1d, a line "# randint(1,5, numpts)," is commented out in line 78, suggesting the users that the input may be an array of integers.

With the above observations, we decided to simply delete the commented out line mentioned in 2 to avoid confusion as the solution to the issue closes #846