search

enthought / chaco

Chaco is a Python package for building interactive and custom 2-D plots.
http://docs.enthought.com/chaco/
Other
292 stars 99 forks source link

fix world_map demo with new link #864

Closed homosapien-lcy closed 1 year ago

homosapien-lcy commented 1 year ago

The chaco/examples/demo/world_map demo example is broken due to the original image link in the example has expired. This PR replaces it with a new example.

dpinte commented 1 year ago

Can you add a comment to the example with the attribution of the image copyright. From wikimedia, it sounds like "Strebe, Public domain, via Wikimedia Commons" would be good and maybe a link to the page (https://commons.wikimedia.org/wiki/File:Winkel_triple_projection_SW.jpg)

homosapien-lcy commented 1 year ago

So, is this issue ready for close?

corranwebster commented 1 year ago

~You might want to merge in main to check that everything passes.~ Sorry, thought this was Enable repo.

homosapien-lcy commented 1 year ago

Somehow I still cannot merge this due to CI test error (which comes from MacOS RuntimeError: NumPy was built with baseline optimizations: (SSE SSE2 SSE3 SSSE3 SSE41 POPCNT SSE42 AVX F16C AVX2) but your machine doesn't support: (AVX2).), I think this is an issue we can pass for now?

corranwebster commented 1 year ago

Somehow I still cannot merge this due to CI test error (which comes from MacOS RuntimeError: NumPy was built with baseline optimizations: (SSE SSE2 SSE3 SSSE3 SSE41 POPCNT SSE42 AVX F16C AVX2) but your machine doesn't support: (AVX2).), I think this is an issue we can pass for now?

Yes, this is due to a change in the EDM mac numpy build. We need to turn off some of the mac tests.

corranwebster commented 1 year ago

I've made the MacOS tests no longer required, so this should be able to be merged despite the failure.