enthought / distarray

Default Repo description from terraform module

BSD 3-Clause "New" or "Revised" License

5 stars 1 forks source link

Use validator from Distributed Array Protocol in tests #137

Open bgrant opened 10 years ago

bgrant commented 10 years ago

The Distributed Array Protocol repo include a validator for distbuffer data structures. We should use this in our tests, particularly in distarray/local/tests/paralleltest_distributed_array_protocol to avoid duplicating work.

kwmsmith commented 10 years ago

@bgrant now that the validator is merged in, can this issue be resolved? Should it wait until 0.3 (or at least after the next protocol release)?

bgrant commented 10 years ago

@kwmsmith : partial resolution.

kwmsmith commented 10 years ago

Does #273 fully resolve this issue, then?

bgrant commented 10 years ago

It's the MVP for it. We could go further, but maybe we should make a new issue for 0.3.

kwmsmith commented 10 years ago

+1 on new 0.3 issue.

markkness commented 10 years ago

273 has been merged. Is this closeable now?

bgrant commented 10 years ago

I would say move it to 0.3 --- there are a couple of TODOs in the code related to checking with the validator.

kwmsmith commented 10 years ago

@bgrant any chance the TODOS can be resolved and this issue closed in the near term?

bgrant commented 10 years ago

Moving to wishlist.