enthought / edge-examples

Example applications and related documentation for Edge
1 stars 0 forks source link

Copy entire src folder into the Dockerfile image #109

Closed EdwinWiseOne closed 2 weeks ago

EdwinWiseOne commented 2 weeks ago

From support ticket #167:

User suggests to copy over all ./src into the image for an easier user experience. See comment:

... working in the Streamlit project created with the Edge CLI. Looking in the DockerFile, I think only app.py is getting copied over by default. We can of course modify the Dockerfile, but why not just copy over all of ./src into the image for an easier UX? I can see users adding modules to src, running edge app build, and then wondering why they are getting import errors.

I would be more in favor of including everything by default rather than trying to guess what should be included with filters. If it is in the src folder chances are good that it is required. It think it would be easier for users to exclude some files manually to attempt to optimize image size than trying to modify a filter that may exclude files required. I would rather optimize than debug.

cc @EdwinWiseOne @dpinte