Add a volume rendering widget and example

enthought / ensemble

High-level widgets for building Python applications

Other

4 stars 7 forks source link

Add a volume rendering widget and example #2

Closed jwiggins closed 10 years ago

jwiggins commented 10 years ago

Second and final code dump... To run the example, you'll need an HDF5 file that has at least one uint8 or uint16 3D array.

jwiggins commented 10 years ago

Alright, thanks to @tonysyu you don't need any special volume data file(s) to test this PR!

ATTN Mayavi/VTK people: (@senganal, @dmsurti, @prabhuramachandran, @rkern?) Can one of y'all maybe take a look at this?

jwiggins commented 10 years ago

I've incorporated Tony's feedback and merged master in hopes of getting a clean Travis build. We shall see...

tonysyu commented 10 years ago

Looks like this builds cleanly! This looks good to me. (I'm still not crazy about lerp, but I don't care enough to push.) I'll plan on merging it tomorrow unless someone else wants to have a look before then.

itziakos commented 10 years ago

how about some tests?

tonysyu commented 10 years ago

Thanks for adding the test. :+1:

itziakos commented 10 years ago

This pr looks that it has been merged without any additional tests.

itziakos commented 10 years ago

correction my github paged needed update. However, I would expect individual tests for the new classes added. Furthermore, according to coveralls merging the PR reduced the test coverage to 46% from 69% (https://coveralls.io/builds/614540). I also fixed the badge at the description that was pointing to the wrong branch.