More Fixes: Volume viewer vtk6 compatibility

enthought / ensemble

High-level widgets for building Python applications

Other

4 stars 7 forks source link

More Fixes: Volume viewer vtk6 compatibility #44

Closed dmsurti closed 9 years ago

dmsurti commented 9 years ago

This fixes:

the bounding box outline filter which needs an update and
MaskImage which has a different API for setting mask and image inputs in VTK 6.x onwards.

mdickinson commented 9 years ago

Would it be possible to have some tests for these changes?

jwiggins commented 9 years ago

@mdickinson: I had the same thought. I think the bounding box stuff is hard to test more than it's already being tested. However, a test for VolumeData that exercises the masking shouldn't be too hard.

dmsurti commented 9 years ago

Added tests for masking volume data and bounding box.

dmsurti commented 9 years ago

@pberkes Updated as per review comments. Please review.

pberkes commented 9 years ago

Merging