search

enthought / ensemble

High-level widgets for building Python applications
Other
4 stars 7 forks source link

Fix unit test failures on TravisCI #7

Closed jwiggins closed 10 years ago

jwiggins commented 10 years ago

The tests pass on OS X, so maybe this pull request will fix things on Travis?

Coverage Status

jwiggins commented 10 years ago

:confounded:

jwiggins commented 10 years ago

:confetti_ball: Finally.

itziakos commented 10 years ago

@jwiggins, I have updated the coverage badge in the description to show the right percentage.

Please make sure that the correct branch is mentioned in both places.

[![Coverage Status](https://coveralls.io/repos/enthought/ensemble/badge.png?branch=fix/ctf-test-failures)] (https://coveralls.io/r/enthought/ensemble?branch=fix/ctf-test-failures)
itziakos commented 10 years ago

I also think that we need to merge master back into this branch so that the coveralls badge shows the coverage relative to the current master.

itziakos commented 10 years ago

@jwiggins, I have not spent time working no this issue yet, but I have not forgotten about it, please bare with me a little longer.

jwiggins commented 10 years ago

@jwiggins, I have not spent time working no this issue yet, but I have not forgotten about it, please bare with me a little longer.

Keep your shirt on, it's not that urgent.

jwiggins commented 10 years ago

I'm in favor of merging this now and dealing with coverage in a separate PR. Thoughts, @itziakos?

itziakos commented 10 years ago

I would prefer that we at least kept the coverage at the same level. But, I think that we need to improve the enable test assistant to allow testing this editor in more detail. I will try to get something in enable before the end of the week, If you need this functionality in master before the end of the week you can merge, but please add an issue to revisit the tests for this PR.

jwiggins commented 10 years ago

I'll add an issue. I'd like to close this branch out.