search

enthought / envisage

Envisage is a Python-based framework for building applications whose functionalities can be extended by adding "plug-ins".
http://docs.enthought.com/envisage/
Other
82 stars 26 forks source link

Revert PR #354 #418

Closed rahulporuri closed 3 years ago

rahulporuri commented 3 years ago

This PR reverts PR #354 from the maint/6.0 branch. This PR seems to be the cause of the issue #417 so once this PR is merged into the maintenance branch, we will be making a bugfix release - 6.0.1.

This PR also undoes a change to the plugin test case made in PR #401. Because we cannot use observe to listen to changes in an extension point anymore, the conversion from _*_changed to observe needed to be undone.

Note that we aren't reverting #354 from the main branch - the issue #417 isn't being closed and it won't be closed until the issue is fixed on the main branch.

mdickinson commented 3 years ago

Thanks @aaronayres35 and @rahulporuri. We should double check that the new test in #421 passes with this PR. (Though that check can be done post-merge if we want to live a little bit dangerously.)

rahulporuri commented 3 years ago

closing in favor of #422