search

enthought / envisage

Envisage is a Python-based framework for building applications whose functionalities can be extended by adding "plug-ins".
http://docs.enthought.com/envisage/
Other
82 stars 26 forks source link

Don't raise SystemError #442

Closed mdickinson closed 1 year ago

mdickinson commented 3 years ago

Various parts of Envisage deliberately do a raise SystemError. SystemError is almost certainly the wrong exception type to be raising in any part of Envisage. From the docs:

Raised when the interpreter finds an internal error, but the situation does not look so serious to cause it to abandon all hope. The associated value is a string indicating what went wrong (in low-level terms).

We should replace each use of SystemError with something more appropriate.

mdickinson commented 1 year ago

There's a WIP PR for this. We should consider tackling this before the 7.0.0 release.