Closed mdickinson closed 1 year ago
This PR is ready for review.
One additional question - does this need any changes to the setup.py optional dependencies for ipython?
does this need any changes to the setup.py optional dependencies for ipython
Unfortunately not: it moves us a bit towards being able to relax the current version constraints, but we don't get all the way there.
This PR contains some minor compatibility fixes for ipykernel versions 6.0.0 and later. There's still significant work to do before we have full compatibility - this is really just clearing away some of the weeds so that we can see the real issues.
Details
capture_fd_output=False
when creating theIPKernelApp
. This prevents the kernel application from setting up threads for stdout and stderr redirection. Those threads have been causing shutdown issues.log_connection_info
, we set either the_ports
traitlet or theports
traitlet; whichever works first (this trait was renamed at some point in the ipykernel history)ipykernel
sets the history manager trait toNone
whenatexit_operations
is called, so that we can no longer retrieve the history manager after callingatexit_operations
.IPython
has deleted theIPython.utils.io.stdout
andIPython.utils.io.stderr
attributes; update our cleanup code to allow for this caseRelated upstream issues: