Closed prabhuramachandran closed 1 year ago
@rahulporuri -- thanks, not sure what the pip errors are here but requesting someone to please merge this when possible.
We do need to get to the bottom of the CI issues before we merge, even if that's just verifying that the same issue exists on the main branch, so that it's independent of this PR.
Unfortunately I won't have bandwidth for that in the near future.
I ran the test-with-pypi workflow on main; indeed it's failing in the same way: https://github.com/enthought/envisage/actions/runs/3264826259
The issue appears to be coming from Pyface: https://github.com/enthought/pyface/issues/1163
Changes look good. But this is a bugfix, so it should really have a regression test. @prabhuramachandran: is there something that could be stolen from Mayavi that would act as a suitable regression test?
I have added the smallest possible test, a simple import catches the error. I hope this is good enough?
@mdickinson -- I added probably the most trivial of tests. It fails without the changes and passes with them.
Looks like I may have messed up something in the commit, I am not sure but the test errors seem unrelated here.
@mdickinson -- is there anything else needed for this?
is there anything else needed for this?
Just the flake8 fix, I think (see https://github.com/enthought/envisage/pull/485/commits/754bd86ea9cfbb5a896c633394dfe9e145d4e11d). I'll merge when/if the checks pass.
Merged. Thanks for the fix.
Fixes https://github.com/enthought/mayavi/issues/1182