search

enthought / envisage

Envisage is a Python-based framework for building applications whose functionalities can be extended by adding "plug-ins".
http://docs.enthought.com/envisage/
Other
81 stars 26 forks source link

Make test egg generation more reliable #499

Closed swt2c closed 1 year ago

swt2c commented 1 year ago

1) Use sys.executable instead of 'python' to generate eggs to ensure the eggs are generated for the currently running python version.

2) Ensure the egg generation is run with a clean environment (stray environment variables caused problems on Debian, for instance).

mdickinson commented 1 year ago

Thanks for the contribution! It looks as though we've got failures on Windows; I'll investigate at some point.

At a guess, there's some part of the environment that we do need to pass on for things to work on Windows.

mdickinson commented 1 year ago

I dug into the Windows failures a bit last night, on a Windows VM. The tests failed for me, but not in exactly the same way as above.

@swt2c Would you object to me breaking off the sys.executable change into a separate PR? That part's a clear bug, and should be an easy fix. The environment manipulation is looking more involved.

swt2c commented 1 year ago

No objections here. I was planning to look into the Windows issue further myself, or perhaps I could figure out which environment variable(s) are causing problems on Debian and just remove those? It's possible the problems I'm seeing are Debian specific, as I didn't see any problems on Fedora after I switched to sys.executable.

swt2c commented 1 year ago

I removed the env change for now and just left the sys.executable one.

mdickinson commented 1 year ago

I've opened #501 for the environment variable issue. At least on Windows + EDM that's probably one that needs internal investigation.