search

enthought / envisage

Envisage is a Python-based framework for building applications whose functionalities can be extended by adding "plug-ins".
http://docs.enthought.com/envisage/
Other
81 stars 26 forks source link

TasksApplication.run should call stop #502

Closed mdickinson closed 1 year ago

mdickinson commented 1 year ago

The run method of the TasksApplication should call stop, so that plugins are stopped properly as the application exits.

Note that the base Application class does call stop in its run method, and in downstream applications that use the TasksApplication we're overriding run, and also calling stop in that overridden method.

mdickinson commented 1 year ago

This is essentially a duplicate of #221, which has more information. We are calling stop in a typical TasksApplication lifecycle, but we're calling it before exiting the event loop.

mdickinson commented 1 year ago

Duplicate of #221